Add DDF for Sinope sp2610zb smart plug and TH1124ZB Thermostat #5962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using eval function to get right values
BabaIsYou
changed the title
Delete blank lines
Adding support for Power in ZHAComsumption that was not correctly updated without DDF
|
Adding DDF to have ZHAComsumption power updated and voltage divided by 10 for TH1124ZB. |
BabaIsYou
changed the title
|
PR looks fine to me, since DDF read/write/parse functions don't depend on the ZCLDB general.xml file this PR should work even without #5904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using eval function to get right values